Skip to content

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

Update NYSE holidays (fix New Year's Day observed and some special holidays).
Closes #1583.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico requested a review from arkid15r as a code owner December 6, 2023 19:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7119162732

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7117547861: 0.0%
Covered Lines: 10286
Relevant Lines: 10286

💛 - Coveralls

@arkid15r arkid15r added this pull request to the merge queue Dec 7, 2023
Merged via the queue into vacanza:beta with commit 2c890a2 Dec 7, 2023
@KJhellico KJhellico deleted the fix-nyse branch December 7, 2023 09:15
@arkid15r arkid15r mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NYSE holidays incorrectly includes new years eve (2021/12/31) when new years day (2022/01/01) falls on Saturday

3 participants