Skip to content

Conversation

@jose1711
Copy link
Contributor

Proposed change

Add Slovak translation of holidays in Czech Republic.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the [contributing guidelines][contributing-guidelines]
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@coveralls
Copy link

coveralls commented Nov 24, 2023

Pull Request Test Coverage Report for Build 6985860295

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%

Totals Coverage Status
Change from base Build 6974101426: 0.0%
Covered Lines: 10288
Relevant Lines: 10288

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
thanks for localizing this!

@KJhellico
Copy link
Collaborator

And l10n test needs to be added for new language.

@KJhellico KJhellico added the l10n label Nov 24, 2023
@arkid15r
Copy link
Collaborator

And l10n test needs to be added for new language.

Good point. We normally add tests too. @jose1711 if you're not familiar with that area you can offload it on me -- I'll submit it in a separate PR

@jose1711
Copy link
Contributor Author

@jose1711 if you're not familiar with that area you can offload it on me -- I'll submit it in a separate PR

Thank you, I'd appreciate if you take over.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arkid15r arkid15r changed the title Add Slovak translation of Czech holidays. Update Czech holidays: add sk localization Nov 25, 2023
@arkid15r arkid15r changed the title Update Czech holidays: add sk localization Update Czechia holidays: add sk localization Nov 25, 2023
@arkid15r
Copy link
Collaborator

Thank you, I'd appreciate if you take over.

You got it!

@arkid15r arkid15r enabled auto-merge November 25, 2023 00:39
@arkid15r arkid15r added this pull request to the merge queue Nov 25, 2023
Merged via the queue into vacanza:beta with commit 171a136 Nov 25, 2023
@arkid15r arkid15r mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants