-
-
Notifications
You must be signed in to change notification settings - Fork 560
Update Czechia holidays: add sk localization #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 6985860295Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
thanks for localizing this!
|
And l10n test needs to be added for new language. |
Good point. We normally add tests too. @jose1711 if you're not familiar with that area you can offload it on me -- I'll submit it in a separate PR |
Thank you, I'd appreciate if you take over. |
|
Kudos, SonarCloud Quality Gate passed!
|
You got it! |








Proposed change
Add Slovak translation of holidays in Czech Republic.
Type of change
Checklist
make pre-commitcommand generates no changesmake test,make tox(we strongly encourage adding tests to your code)