Skip to content

Add categories and subdivisions support to substituted holidays #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2023
Merged

Add categories and subdivisions support to substituted holidays #1558

merged 3 commits into from
Nov 30, 2023

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

Add categories support to substituted holidays (substituted_public_holidays etc.).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@KJhellico KJhellico requested a review from arkid15r as a code owner November 16, 2023 16:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6893873396

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%
Totals Coverage Status
Change from base Build 6882222366: 0.0%
Covered Lines: 10288
Relevant Lines: 10288
💛 - Coveralls

@KJhellico
Merge branch 'beta' into add-substituted-categories
e1e0963 
# Conflicts:
#	holidays/holiday_base.py
@KJhellico KJhellico changed the title Add categories support to substituted holidays Add categories and subdivisions support to substituted holidays Nov 28, 2023
@KJhellico KJhellico force-pushed the add-substituted-categories branch from aec9ea0 to 3077dcd Compare November 29, 2023 12:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

arkid15r
arkid15r approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have a couple of ideas on how to improve this. I'm going to add them together with #1559 related changes

@arkid15r arkid15r added this pull request to the merge queue Nov 30, 2023
Merged via the queue into vacanza:beta with commit 59dde59 Nov 30, 2023
@KJhellico KJhellico deleted the add-substituted-categories branch November 30, 2023 08:14
@arkid15r arkid15r mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @coveralls @arkid15r