Skip to content

Update Turkey holidays: add holiday categories and l10n support #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 15, 2023
Merged

Update Turkey holidays: add holiday categories and l10n support #1556

merged 5 commits into from
Nov 15, 2023

Conversation

@KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Nov 13, 2023

Proposed change

Update Turkey holidays: add holiday categories (HALF_DAY, PUBLIC) and l10n support (en_US, tr, uk).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@KJhellico KJhellico requested a review from arkid15r as a code owner November 13, 2023 18:41
@coveralls
Copy link

coveralls commented Nov 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6882131191

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 54 of 54 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%
Totals Coverage Status
Change from base Build 6854436239: 0.0%
Covered Lines: 10278
Relevant Lines: 10278
💛 - Coveralls

arkid15r
arkid15r reviewed Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@arkid15r arkid15r enabled auto-merge November 15, 2023 19:53
@arkid15r arkid15r added this pull request to the merge queue Nov 15, 2023
Merged via the queue into vacanza:beta with commit cd69beb Nov 15, 2023
@KJhellico KJhellico deleted the upd-turkey branch November 16, 2023 10:59
@KJhellico KJhellico mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @coveralls @arkid15r