Skip to content

Conversation

@KJhellico
Copy link
Collaborator

Proposed change

Update Spain holidays in 2024, according to Resolution of Directorate General of Labor.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@KJhellico KJhellico requested a review from arkid15r as a code owner October 28, 2023 14:27
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
27.2% 27.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6677494350

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%

Totals Coverage Status
Change from base Build 6658682592: 0.0%
Covered Lines: 10066
Relevant Lines: 10066

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great accuracy improvement PR! Let's merge it and deal with the code duplication warnings later!

🇪🇸 LGTM

@arkid15r arkid15r added this pull request to the merge queue Nov 7, 2023
Merged via the queue into vacanza:beta with commit a641ec1 Nov 7, 2023
@KJhellico KJhellico deleted the upd-spain-2024 branch November 8, 2023 14:12
@KJhellico KJhellico mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants