Skip to content

Update South Korea holidays, add l10n support #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 8, 2023
Merged

Update South Korea holidays, add l10n support #1536

merged 15 commits into from
Nov 8, 2023

Conversation

@PPsyrius
Copy link
Collaborator

Proposed change

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@PPsyrius
Copy link
Collaborator Author

This PR is marked as a draft to wait for #1535 's eventual merge (mostly so that we can include the historic, short observances in 1959-1960, 1989 done (as seen here; Point 4.2.1 Before the 2010s ).

@coveralls
Copy link

coveralls commented Oct 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6793343944

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 75 of 75 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.978%
Totals Coverage Status
Change from base Build 6775600278: 0.0%
Covered Lines: 10200
Relevant Lines: 10200
💛 - Coveralls

KJhellico
KJhellico reviewed Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PPsyrius, it's just great!

@PPsyrius
Copy link
Collaborator Author

Turns out #1535's new special_holidays_observed requires the usage of ObservedHolidayBase

We may as well go and revamp the existing codes for _add_alt_holiday( ) and _add_three_day_holiday( ) at this rate, as the change to the new observed class requires at least one observed_rule.

@KJhellico
Copy link
Collaborator

I'm trying to migrate South Korea to ObservedHolidays, but I'm not satisfied with the result yet. Their rules are quite complex and unique.

@PPsyrius PPsyrius marked this pull request as ready for review October 31, 2023 12:07
@PPsyrius PPsyrius requested a review from arkid15r as a code owner October 31, 2023 12:07
arkid15r
arkid15r reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smooth migration plus l10n, 2 in 1!

A few suggestions:

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@arkid15r arkid15r enabled auto-merge November 8, 2023 04:28
arkid15r
arkid15r approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇰🇷 LGTM

@arkid15r arkid15r added this pull request to the merge queue Nov 8, 2023
Merged via the queue into vacanza:beta with commit e8faf97 Nov 8, 2023
@PPsyrius PPsyrius deleted the south_korea_l10n branch November 8, 2023 04:44
@KJhellico KJhellico mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico left review comments

@arkid15r arkid15r arkid15r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PPsyrius @coveralls @KJhellico @arkid15r