Skip to content

Conversation

@KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Sep 27, 2023

Proposed change

Update Belarus holidays: add substituted holidays.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@KJhellico KJhellico requested a review from arkid15r as a code owner September 27, 2023 16:07
@KJhellico KJhellico changed the title Update Belarus holidays: add substitited holidays Update Belarus holidays: add substituted holidays Sep 27, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6330143173

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6268770681: 0.0%
Covered Lines: 9398
Relevant Lines: 9398

💛 - Coveralls

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I love the way we harvest fruits of our previous substituted/localized holidays work 👍

@arkid15r arkid15r added this pull request to the merge queue Sep 28, 2023
Merged via the queue into vacanza:beta with commit 0d08573 Sep 28, 2023
@KJhellico KJhellico deleted the upd-belarus branch September 28, 2023 15:53
@arkid15r arkid15r mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants