This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Expose CURLResponse.Error as CurlyError and map libCurl error codes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to be able to manage CurlyClient's error precisely
and convert the CurlyError.code property from Int to Code Add a test to check that any new error code introduced by libCurl will be catched in a failed test
|
Sweet, thank you! I'll merge it in and tag a new version soon. |
# Conflicts: # Tests/CurlyClientTests/CurlyClientTests.swift
vzsg
added a commit
that referenced
this pull request
Jun 11, 2019
There was a side-effect in PR #1 that I noticed after merging: CURLResponse at this point in time should not be public, as none of its functionality is exposed (especially not for successful requests). To undo the leak, I moved the error into a separate, public struct with a public enum and hid CURLResponse again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds a feature that allows
Curlyclients to analyse errors thrown by the service with more precision.CURLResponse.Errorpublicly (as in the original Perfect version)CurlyErrortype alias ofCURLResponse.Errorfor shorter syntaxCurlyError.Codeenum that maps the internalCURLcodeenum fromlibCurl