feat(app): app.runWithContext() #7451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also think it's worth giving functions like the callback passed to |
b137661 to
ae26bff
Compare
antfu
approved these changes
Mar 13, 2023
sxzz
approved these changes
Mar 14, 2023
Allows accessing globals provided at the app level with `app.provide()` via a regular `inject()` call as long as you have access to the application. Useful for Pinia, vue-router, Nuxt, Quasar, and other advanced use cases. - vuejs/pinia#1784
ae26bff to
afed3c3
Compare
8 tasks
IAmSSH
pushed a commit
to IAmSSH/core
that referenced
this pull request
May 14, 2023
posva
added a commit
to posva/tanstack-query-fork
that referenced
this pull request
Aug 18, 2023
This feature requires Vue 3.3.0, which has been out for a while now. It allows using vue-query APIs in places where it is valid to use them but currently throws an error. - `hasInjectionContext()`: vuejs/core#8111 - `app.runWithContext()`: vuejs/core#7451
DamianOsipiuk
pushed a commit
to posva/tanstack-query-fork
that referenced
this pull request
Aug 25, 2023
This feature requires Vue 3.3.0, which has been out for a while now. It allows using vue-query APIs in places where it is valid to use them but currently throws an error. - `hasInjectionContext()`: vuejs/core#8111 - `app.runWithContext()`: vuejs/core#7451
DamianOsipiuk
pushed a commit
to posva/tanstack-query-fork
that referenced
this pull request
Aug 25, 2023
This feature requires Vue 3.3.0, which has been out for a while now. It allows using vue-query APIs in places where it is valid to use them but currently throws an error. - `hasInjectionContext()`: vuejs/core#8111 - `app.runWithContext()`: vuejs/core#7451
DamianOsipiuk
added a commit
to TanStack/query
that referenced
this pull request
Aug 30, 2023
* feat(vue-query): support injectable contexts This feature requires Vue 3.3.0, which has been out for a while now. It allows using vue-query APIs in places where it is valid to use them but currently throws an error. - `hasInjectionContext()`: vuejs/core#8111 - `app.runWithContext()`: vuejs/core#7451 * refactor: add dev warning for effectScope * fix: add memory leak warnings, fix tests * chore: bump vue-demi * chore: bump vue version in integrations --------- Co-authored-by: Damian Osipiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows accessing globals provided at the app level with
app.provide()via a regularinject()call as long as you have access to the application. Useful for Pinia, vue-router, Nuxt, Quasar, VueUse, and other advanced use cases.I named the function
runWithContext()to look likeeffect.run()but maybe it should be named something different likerunWithProvides()since it only ensuresinject()behavior but I think keeping a more generic names allows to add other things if the future likeonServerPrefetch()and so.