Feature/issue 43 fix should allow violation #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed the existing test to testTextField_AllowedViolations_and_validateOnFocusLossOnly to better characterize the test.
…Field and ValidatorTextView.
Current coverage is 54.94% (diff: 0.00%)@@ master #44 diff @@
==========================================
Files 35 35
Lines 526 526
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 252 289 +37
+ Misses 274 237 -37
Partials 0 0
|
|
Sorry it's taken me a while to review this @sparrowlegs ! I hope to get to it in the next few days. |
Contributor
Author
|
@aamctustwo It's cool. Thanks for responding. I was worried that PR didn't follow your coding conventions. |
ghost
pushed a commit
that referenced
this pull request
Jan 20, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes
ValidatorTextFieldandValidatorTextViewto behave correctly when theshouldAllowViolationproperty is set totrue.This also changes
ValidatorTextFieldandValidatorTextViewto initialize with a default offalsefor theshouldAllowViolationproperty. Doing this better matches the intent of the documentation.See issue
#43for more detail.