Skip to content

Remove the 'urllib3.request' module #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Remove the 'urllib3.request' module #2398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/2269.removal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Removed the ``urllib3.request`` module. ``urllib3.request.RequestMethods`` has been made a private API.

This change was made to ensure that ``from urllib3 import request`` imported the top-level ``request()``
function instead of the ``urllib3.request`` module.
1 change: 0 additions & 1 deletion docs/reference/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@ API Reference
urllib3.exceptions
urllib3.response
urllib3.fields
urllib3.request
urllib3.util
contrib/index
7 changes: 0 additions & 7 deletions docs/reference/urllib3.request.rst
View file
Open in desktop

This file was deleted.

0 src/urllib3/request.py → src/urllib3/_request_methods.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/urllib3/connectionpool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from types import TracebackType
from typing import TYPE_CHECKING, Any, Mapping, Optional, Type, TypeVar, Union, overload

from ._request_methods import RequestMethods
from .connection import (
_TYPE_BODY,
BaseSSLError,
Expand Down Expand Up @@ -38,7 +39,6 @@
SSLError,
TimeoutError,
)
from .request import RequestMethods
from .response import BaseHTTPResponse, HTTPResponse
from .util.connection import is_connection_dropped
from .util.proxy import connection_requires_http_tunnel
Expand Down
2 changes: 1 addition & 1 deletion src/urllib3/poolmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from urllib.parse import urljoin

from ._collections import RecentlyUsedContainer
from ._request_methods import RequestMethods
from .connection import ProxyConfig
from .connectionpool import HTTPConnectionPool, HTTPSConnectionPool, port_by_scheme
from .exceptions import (
Expand All @@ -26,7 +27,6 @@
ProxySchemeUnknown,
URLSchemeUnknown,
)
from .request import RequestMethods
from .response import BaseHTTPResponse
from .util.connection import _TYPE_SOCKET_OPTIONS
from .util.proxy import connection_requires_http_tunnel
Expand Down