Add map value source #2009
Merged
Add map value source #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juneezee
reviewed
Nov 21, 2024
|
Is it the "map value" or the map of value sources? For debugging and bug reports it might be useful to have a structure and output that shows where option is sets, and which value is selected finally. Like: |
It is a map-value source i.e a source which can lookup values based on key. |
Juneezee
approved these changes
Nov 22, 2024
meatballhat
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
I agree with @abitrolly that mapValueSource is a bit confusing, but I follow your reasoning 😅👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
In order to make the cli-altsrc more modular in terms on its provider it seems to be better if map value source can be incorporated directly into cli.
Which issue(s) this PR fixes:
(REQUIRED)
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
go test -run=TestMapValueSource
Release Notes
(REQUIRED)