v2 master merge #892
Merged
v2 master merge #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overwrite slice flag defaults when set
This was introduced by #36, but only worked in the specific case of all arguments being passed before all flags. If the user mixed them, they ended up with odd parsing behavior where the arguments were reordered (causing #103 and #355). Given the tradeoffs I think we should remove support for flag reordering. Fixes #103 Fixes #355
Remove reordering of flags and arguments
and change the behavior of the non-Global variants to always search up the context lineage. Closes #385
per feedback on #410
Remove deprecated things and supporting code
Remove all Context.Global* methods
Replace BoolTFlag type with BoolFlag.Value
now that BoolTFlag is gone
and alter the Flag interface accordingly Closes #415
Replace all "stringly typed" fields with slice equivalents
by using pointer func receivers and slices of struct pointers where possible.
Merging from master/v1
Member
|
😎 this is looking ready to merge 😎 |
Member
|
I'm gonnaaaaaaaa merge it |
|
Is there some background on what just happened, because all our builds just broke. Thanks! |
Member
|
For any future people reading this, follow-up on this PR is happening on these issues: |
erikwilson
pushed a commit
to rancher/spur
that referenced
this pull request
Jun 8, 2020
This was referenced May 21, 2021
Closed
This was referenced Jun 1, 2021
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
view the v2 release notes here => https://github.com/urfave/cli/releases/tag/v2.0.0
edited by @lynncyrin!