Skip to content

http: actually fix the leak #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

http: actually fix the leak #902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions pkg/vere/io/http.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ _get_beam(u3_hreq* req_u, c3_c* txt_c, c3_w len_w)
return bem;
}

/* _http_req_dispatch(): dispatch http request
/* _http_req_dispatch(): dispatch http request. RETAINS `req`
*/
static void
_http_req_dispatch(u3_hreq* req_u, u3_noun req)
Expand All @@ -963,7 +963,7 @@ _http_req_dispatch(u3_hreq* req_u, u3_noun req)
u3_noun adr = u3nc(c3__ipv4, u3i_words(1, &req_u->hon_u->ipf_w));
// XX loopback automatically secure too?
//
u3_noun dat = u3nt(htp_u->sec, adr, req);
u3_noun dat = u3nt(htp_u->sec, adr, u3k(req));

cad = ( c3y == req_u->hon_u->htp_u->lop )
? u3nc(u3i_string("request-local"), dat)
Expand All @@ -972,9 +972,6 @@ _http_req_dispatch(u3_hreq* req_u, u3_noun req)
}
else {
// '/_~_/' found
// `req` is unused, free it
//
u3z(req);
bas_c = bas_c + 4; // retain '/' after /_~_
len_w = len_w - 4;

Expand Down Expand Up @@ -1100,6 +1097,9 @@ _http_cache_respond(u3_hreq* req_u, u3_noun nun)
u3_hreq* req_u = _http_req_prepare(rec_u, _http_req_new);
_http_req_dispatch(req_u, req);
}
// can be u3_none
//
u3z(req);
}
else if ( u3_none == u3r_at(7, nun) ) {
h2o_send_error_500(rec_u, "Internal Server Error", "scry failed", 0);
Expand Down Expand Up @@ -1672,6 +1672,10 @@ _http_rec_accept(h2o_handler_t* han_u, h2o_req_t* rec_u)
}
}

// can be u3_none
//
u3z(req);

return 0;
}

Expand Down