Skip to content

Conversation

userquin
Copy link
Member

@userquin userquin commented Jan 26, 2025

Using read-yaml-file instead yaml => it is small, check them at pgk-size:

@jacob-8 @Aslemammad

Check screenshot here #4397 (comment) versus:

imagen

@userquin userquin requested review from antfu and zyyv as code owners January 26, 2025 12:03
Copy link

netlify bot commented Jan 26, 2025

Deploy Preview for unocss ready!

Name Link
🔨 Latest commit c6e50e9
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/6796248f000bab0008134a1f
😎 Deploy Preview https://deploy-preview-4407--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 26, 2025

Open in Stackblitz

commit: c6e50e9

@antfu
Copy link
Member

antfu commented Jan 26, 2025

I would wish pkg-pr-new handles it automatically instead of us patching it

@userquin
Copy link
Member Author

I would wish pkg-pr-new handles it automatically instead of us patching it

I'm talking with @Aslemammad, this is a temporary patch here... maybe we can add some utility since we need to provide the packages globs to pkg-pr-new to patch the packages before publishing

@antfu
Copy link
Member

antfu commented Jan 26, 2025

Would running pnpm publish instead of npm publish in pkg-pr-new solve this? pnpm publish automatically resolves the catalog and workspace tag

@userquin
Copy link
Member Author

userquin commented Jan 26, 2025

The problem is about ignoring the package.json file when running pnpm pack, it is not being used and pkg-pr-new should merge the package.json dependencies with the generated by the pack command.

@userquin
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants