fix(node:events): call to Array.prototype.slice with context
#518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is returning an empty array when listeners are > 6
williamkapke
added a commit
to elevationai/cuss2-ts
that referenced
this pull request
Sep 3, 2025
- Added vendor/node-events-fixed.ts with arrayClone bug fix - The bug: Array.prototype.slice(arr) should be Array.prototype.slice.call(arr) - This causes "Cannot read properties of undefined (reading 'apply')" with >6 listeners - Updated import map to use local fixed version instead of node:events - Added return types to satisfy deno lint no-slow-types rule - This is temporary until unjs/unenv#518 is merged and deployed
Array.prototype.slice with context
|
Released (https://github.com/unjs/unenv/releases/tag/v2.0.0-rc.21) also cross merged to (https://github.com/unjs/node-mock-http/releases/tag/v1.0.3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix call to Array.prototype.slice with context
Description
This PR fixes a critical bug in the EventEmitter polyfill where
Array.prototype.sliceis called without proper context, causing a runtime error when an EventEmitter has more than 6 listeners.The Bug
The current implementation has a typo in the array cloning function:
This causes
TypeError: Cannot read properties of undefined (reading 'apply')when emitting events with >6 listeners.How to Reproduce