Skip to content

Conversation

jasnell
Copy link
Contributor

@jasnell jasnell commented Aug 2, 2025

Fixes: #512

@pi0 pi0 changed the title Fix tty default export for ReadStream fix(node): tty default export for ReadStream Aug 3, 2025
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 merged commit 00ab5d8 into main Aug 3, 2025
2 checks passed
@pi0 pi0 deleted the fixup-tty-polyfill-export branch August 3, 2025 19:08
@pi0
Copy link
Member

pi0 commented Aug 3, 2025

Does this need immediate release?

(fix is already available in nightly channel. i have few more items to batch-in if not urgent)

@vicb
Copy link
Contributor

vicb commented Aug 4, 2025

Hey @pi0
It would be helpful to have a release either today or tomorrow.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node:tty polyfill default export mistakenly exports ReadStream as WriteStream
4 participants