Skip to content

fix(dev): fix absolute paths import on windows #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pi0 merged 1 commit into from
Dec 5, 2023
Merged

fix(dev): fix absolute paths import on windows #142

pi0 merged 1 commit into from
Dec 5, 2023

Conversation

@aaharu
Copy link
Member

@aaharu aaharu commented Dec 1, 2023 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When running ipx's pnpm run dev following environments, failed to import h3Entry in createDevServer.

pnpm run dev 

> [email protected] dev C:\Users\......\github.com\unjs\ipx
> listhen -w playground

ERROR  Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@aaharu aaharu changed the title fix(dev): fix absolute paths imports on windows fix(dev): fix absolute paths import on windows Dec 5, 2023
pi0
pi0 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit d577402 into unjs:main Dec 5, 2023
@pi0 pi0 mentioned this pull request Dec 12, 2023
Closed
8 tasks
@aaharu aaharu deleted the fix-import-path-windows branch December 13, 2023 14:13
@aaharu aaharu mentioned this pull request Dec 13, 2023
Closed
@markthree markthree mentioned this pull request Jan 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aaharu @pi0