Skip to content

fix(serialize): allow input.toJSON() to return any type #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2025
Merged

fix(serialize): allow input.toJSON() to return any type #135

merged 3 commits into from
Mar 4, 2025

Conversation

@zsilbi
Copy link
Collaborator

@zsilbi zsilbi commented Mar 3, 2025

Currently the serializer can only handle object returns from input.toJSON():

class TestString {
  toJSON() {
    return "value";
  }
}
serialize(new TestString()); // Error: Cannot serialize String

There is no rule that toJSON() must return an object type.

For example:

typeof new Date().toJSON(); // string

I added a fix that keeps the current output format for objects, but uses TestString('value') format for others.

@codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (c5173ba) to head (75baaa0).
Report is 88 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #135       +/-   ##
===========================================
+ Coverage   80.31%   95.76%   +15.44%     
===========================================
  Files           8        8               
  Lines        1006      472      -534     
  Branches      111      123       +12     
===========================================
- Hits          808      452      -356     
+ Misses        198       18      -180     
- Partials        0        2        +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pi0
pi0 reviewed Mar 3, 2025
View reviewed changes
pi0
pi0 reviewed Mar 3, 2025
View reviewed changes
@zsilbi @pi0
Update src/serialize.ts
75baaa0 
Co-authored-by: Pooya Parsa <[email protected]>
pi0
pi0 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx!

@pi0 pi0 merged commit 6968b45 into unjs:main Mar 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zsilbi @pi0