Skip to content

Conversation

zyllee
Copy link
Contributor

@zyllee zyllee commented Jun 28, 2023

this is related to issue #270
there's a paper named "FlexOS: Towards Flexible OS Isolation" lack of property link.Because of it,when we click title "FlexOS: Towards Flexible OS Isolation", it will not jump to the related links.

@StefanJum StefanJum self-assigned this Jun 28, 2023
@StefanJum StefanJum linked an issue Jun 28, 2023 that may be closed by this pull request
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zyllee. Please start the commit message and description with capital letters and wrap the commit description lines at ~72 characters. Also I would make the commit message doc/publications: Add correct link to FlexOS paper, just to be more specific.

Everything else looks good, we can merge it after that.

There's a paper named "FlexOS: Towards Flexible OS Isolation" lack of
property `link`.Because of it,when we click title "FlexOS: Towards
Flexible OS Isolation", it will not jump to the related links.

Signed-off-by: Zeyu Li <[email protected]>
@zyllee zyllee force-pushed the amend-publicaitons-links branch from b9f233b to 0cac934 Compare June 28, 2023 14:35
@zyllee zyllee changed the title doc/publications: add correct link to a paper doc/publications: Add correct link to FlexOS paper Jun 28, 2023
@zyllee zyllee requested a review from StefanJum June 28, 2023 14:38
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks.

Reviewed-by: Stefan Jumarea [email protected]
Approved-by: Stefan Jumarea [email protected]

@StefanJum StefanJum merged commit 553d5fc into unikraft:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There's a link in Publications page is not correct.

2 participants