Combo field appearance #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #370 +/- ##
===============================================
- Coverage 56.54% 56.54% -0.01%
===============================================
Files 236 236
Lines 45786 45798 +12
===============================================
+ Hits 25891 25895 +4
- Misses 16555 16563 +8
Partials 3340 3340
Continue to review full report at Codecov.
|
This was referenced Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #270
Partially addresses #341: both the fill and flatten operations work as intended. However, the PDF seems to be invalid the sense that the choice/combo field has an
Iarray with a single value present, which causes the first value in the selection list to always be shown when opening the file. According to the specifications, theIfield should be used only for fields that support multiple selection, which is not the case there. Setting that field to nil before the fill operation should solve the issue (the flatten operation works as intended using the PR, without removing theIvalue). See section 12.7.4.4 "Choice Fields" (pp. 444-446) of the PDF specs for more details.This change is