Skip to content

Fix outline null object check #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

Fix outline null object check #367

merged 1 commit into from
Jun 5, 2020

Conversation

@adrg
Copy link
Collaborator

@adrg adrg commented Jun 5, 2020 •
edited by gunnsth
Loading

This change is Reviewable

gunnsth
gunnsth approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 5, 2020 •
edited
Loading

Codecov Report

Merging #367 into development will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #367   +/-   ##
============================================
  Coverage        56.51%   56.51%           
============================================
  Files              236      236           
  Lines            45825    45825           
============================================
  Hits             25899    25899           
  Misses           16588    16588           
  Partials          3338     3338
Impacted Files Coverage Δ
model/reader.go 48.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5777ee1...6014c14. Read the comment docs.

@gunnsth gunnsth merged commit 6b8d5c4 into unidoc:development Jun 5, 2020
@adrg adrg deleted the outline-null-object branch June 9, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adrg @gunnsth