Skip to content

Double quote content stream operator fixes #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2020
Merged

Double quote content stream operator fixes #313

merged 2 commits into from
Apr 16, 2020

Conversation

@adrg
Copy link
Collaborator

@adrg adrg commented Apr 16, 2020 •
edited by gunnsth
Loading

Resolves #287 and #310.

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 16, 2020 •
edited
Loading

Codecov Report

Merging #313 into development will decrease coverage by 5.87%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #313      +/-   ##
===============================================
- Coverage        62.24%   56.37%   -5.88%     
===============================================
  Files              235      235              
  Lines            45439    45434       -5     
===============================================
- Hits             28285    25613    -2672     
- Misses           16503    16521      +18     
- Partials           651     3300    +2649
Impacted Files Coverage Δ
contentstream/creator.go 51.81% <0.00%> (ø)
contentstream/operand_list.go 100.00% <ø> (ø)
extractor/text.go 63.56% <0.00%> (-7.63%) ⬇️
render/internal/context/text_state.go 0.00% <ø> (ø)
render/renderer.go 0.00% <0.00%> (ø)
internal/e2etest/utils.go 60.00% <0.00%> (-20.00%) ⬇️
ps/exec.go 62.96% <0.00%> (-18.52%) ⬇️
core/security/handlers.go 33.33% <0.00%> (-16.67%) ⬇️
model/optimize/image_ppi.go 58.46% <0.00%> (-16.16%) ⬇️
model/signature_handler.go 55.04% <0.00%> (-15.60%) ⬇️
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a351532...c92242d. Read the comment docs.

gunnsth
gunnsth approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@gunnsth gunnsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunnsth gunnsth merged commit 61ff519 into unidoc:development Apr 16, 2020
@adrg adrg deleted the double-quote-op-fix branch April 21, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gunnsth gunnsth gunnsth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adrg @gunnsth