Skip to content

Conversation

@sampila
Copy link
Collaborator

@sampila sampila commented Apr 15, 2025

Release notes - UniOffice v2.2.0

This release contains improvements and bug fixes

Sub-task

  • US-918 DOCX implement some image effects
  • US-932 Update minimum supported Go version to go 1.20
  • US-919 PPTX to PDF use table cell opacity
  • US-993 Update UniPDF and UniChart version

Bug Fixes

  • US-976 Fix issue with adding a slide to the second page in a PPT/PPTX File

@sampila sampila requested review from 3ace, anovik, Copilot, gunnsth and kellemNegasi and removed request for Copilot April 15, 2025 20:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 56 out of 70 changed files in this pull request and generated no comments.

Files not reviewed (14)
  • go.mod: Language not supported
  • common/tempstorage/diskstore/diskstore.go: Language not supported
  • color/color.go: Language not supported
  • internal/mergesort/mergesort.go: Language not supported
  • drawing/drawing.go: Language not supported
  • common/tempstorage/tempstorage.go: Language not supported
  • common/tempstorage/memstore/memstore.go: Language not supported
  • common/logger/logger.go: Language not supported
  • common/license/license.go: Language not supported
  • algo/algo.go: Language not supported
  • ACKNOWLEDGEMENTS.md: Language not supported
  • internal/mscfb/mscfb.go: Language not supported
  • internal/license/license.go: Language not supported
  • internal/formatutils/formatutils.go: Language not supported
Comments suppressed due to low confidence (4)

schema/purl.org/dc/elements/elements.go:12

  • [nitpick] The import aliases (_d, _dg, _f, _g) are non-descriptive; consider using more meaningful names to improve readability.
package elements ;import (_d "encoding/xml";_dg "fmt";_f "github.com/unidoc/unioffice/v2";_g "github.com/unidoc/unioffice/v2/common/logger";)

internal/testutils/testutils.go:10

  • [nitpick] Numerous abbreviated and non-descriptive variable names reduce code clarity; consider more descriptive naming for maintainability.
package testutils ;import (_ed "crypto/md5";_fc "encoding/hex"; ...)

internal/testutils/testutils.go:12

  • [nitpick] The magic number '1' is used for image size tolerance; define a named constant for the tolerance value to clarify its purpose.
if _d.Abs(float64(_fdgb.Max.X)-float64(_fee.Max.X)) > 1 { ... }

internal/mscfb/rw/rw.go:27

  • Verify that the WriteTo function properly handles cases where the written byte count exceeds expected limits, ensuring the error condition accurately reflects potential issues.
if _dae > _ccd { return 0, error.New("rw.Writer.WriteTo: invalid Write count") };

@sampila sampila marked this pull request as ready for review April 15, 2025 20:09
@gunnsth gunnsth merged commit 3145cd4 into unidoc:master Apr 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants