qt4 immodule: Add missing <clocale> include #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Sorry for the garbled initial pull request description, I've fixed it now) |
|
I prefer "clocale" to "locale.h" in C++ source files |
* qt4/immodule/plugin.cpp
- Stop relying on implicit includes that may not always work and
explicitly include <clocale> for the setlocale(3) call.
|
Fine by me. I've updated the include in the pull request. |
mnogu
added a commit
that referenced
this pull request
Mar 2, 2014
qt4 immodule: Add missing <clocale> include
|
Merged. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit in this pull request adds a missing locale.h include that was being relied upon implicit before. It made the build fail on platforms such as FreeBSD 10, which use libc++ instead of libstdc++ by default.