Add support for the new iPhone 17 line up #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueman
reviewed
Oct 9, 2025
| right: config.horizontal, | ||
| // TODO(ueman): Use ClipRSuperellipse eventually? | ||
| child: ClipRRect( | ||
| child: ClipRSuperellipse( |
There was a problem hiding this comment.
I think we need to set a constraint on the lower end of supported Flutter versions. Otherwise, we might allow this to be used on older Flutter versions, even though it's not actually supported.
There was a problem hiding this comment.
Fair point, though maybe we can safely assume that users won’t be running it on Flutter versions that old. What do you think? 🤔
There was a problem hiding this comment.
@ueman let me know what you would like to do regarding this 🥹
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust Dynamic Island logo for iPhone 17 / Air models
With the arrival of the iPhone 17 lineup, logos that live behind the Dynamic Island need proper alignment. Without support, the logo was just not being shown on the newest iPhones. This change ensures a reasonable default layout.
Moreover we are relying on the new
ClipRSuperellipseto clip more correctly the content behind the Dynamic Island, respecting the Human Interface Guidelines.Testing: