Skip to content

Update authlib and authutils #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update authlib and authutils #1301

wants to merge 1 commit into from

Conversation

jacob50231
Copy link
Contributor

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PPS-2231

Dependency updates

  • authlib 1.6.4
  • authutils 7.0.1

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 15 0 15
tests/test_centralized_auth.py 9 7 0 16
tests/test_data_upload.py 7 1 1 9
tests/test_oidc_client.py 0 2 0 2
tests/test_client_credentials.py 0 1 0 1
tests/test_audit_service.py 3 0 3 6
tests/test_presigned_url.py 7 0 0 7
tests/test_dbgap.py 4 0 1 5
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_google_data_access.py 1 0 0 1
tests/test_ras_authn.py 0 0 3 3
tests/test_register_user.py 0 0 2 2
TOTAL 40 26 10 76

Please find the detailed integration test report here

@github-actions GitHub Actions
Copy link

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 15 0 15
tests/test_centralized_auth.py 9 7 0 16
tests/test_oidc_client.py 0 2 0 2
tests/test_client_credentials.py 0 1 0 1
tests/test_audit_service.py 3 0 3 6
tests/test_data_upload.py 8 0 1 9
tests/test_presigned_url.py 7 0 0 7
tests/test_dbgap.py 4 0 1 5
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_google_data_access.py 1 0 0 1
tests/test_ras_authn.py 0 0 3 3
tests/test_register_user.py 0 0 2 2
TOTAL 41 25 10 76

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions GitHub Actions
Copy link

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 15 0 15
tests/test_centralized_auth.py 9 7 0 16
tests/test_dbgap.py 3 1 1 5
tests/test_oidc_client.py 0 2 0 2
tests/test_client_credentials.py 0 1 0 1
tests/test_audit_service.py 3 0 3 6
tests/test_data_upload.py 8 0 1 9
tests/test_presigned_url.py 7 0 0 7
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_google_data_access.py 1 0 0 1
tests/test_ras_authn.py 0 0 3 3
tests/test_register_user.py 0 0 2 2
TOTAL 40 26 10 76

Please find the detailed integration test report here

Please find the Github Action logs here

@k-burt-uch k-burt-uch force-pushed the chore/bump-authutils branch from dc43450 to ff2c82b Compare October 21, 2025 21:03
k-burt-uch
k-burt-uch reviewed Oct 21, 2025
View reviewed changes
fence/oidc/grants/oidc_code_grant.py
authorization_code = self.query_authorization_code(code, client)
if not authorization_code:
raise InvalidGrantError('Invalid "code" in request.')
raise InvalidGrantError("Invalid 'code' in request.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacob50231 you were right about those double quotes :)

@coveralls
Copy link

coveralls commented Oct 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18700161350

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.07%) to 74.96%
Files with Coverage Reduction New Missed Lines %
blueprints/ga4gh.py 1 94.12%
metrics.py 3 93.48%
oidc/oidc_server.py 5 89.23%
Totals Coverage Status
Change from base Build 18689424640: 0.07%
Covered Lines: 8433
Relevant Lines: 11250
💛 - Coveralls

@k-burt-uch k-burt-uch force-pushed the chore/bump-authutils branch from 864d0f1 to 76fcb4c Compare October 21, 2025 23:04
@jacob50231 @k-burt-uch
Update authlib
6baebc6 
Add amr and acr columns to authorization_code table

Remove double quotes from token validation errors

Use test-client as the azp in unit tests where appropriate

Add README to tests/ to help future devs run unit tests
@k-burt-uch k-burt-uch force-pushed the chore/bump-authutils branch from 76fcb4c to 6baebc6 Compare October 21, 2025 23:07
@github-actions GitHub Actions
Copy link

filepath passed failed error skipped SUBTOTAL
tests/test_oauth2.py 15 0 0 0 15
tests/test_centralized_auth.py 7 9 0 0 16
tests/test_audit_service.py 3 0 0 3 6
tests/test_data_upload.py 2 1 7 1 11
tests/test_user_token.py 2 3 0 0 5
tests/test_ras_authn.py 0 0 0 3 3
tests/test_dbgap.py 0 4 0 1 5
tests/test_register_user.py 0 0 0 2 2
tests/test_presigned_url.py 0 7 0 0 7
tests/test_oidc_client.py 0 2 0 0 2
tests/test_client_credentials.py 0 1 0 0 1
tests/test_drs_endpoint.py 0 0 4 0 4
tests/test_google_data_access.py 0 0 1 0 1
TOTAL 29 27 12 10 78

Please find the detailed integration test report here

Please find the Github Action logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-burt-uch k-burt-uch k-burt-uch left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacob50231 @coveralls @k-burt-uch