Fix/update deny #1299
Merged
Fix/update deny #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18658110816Details
💛 - Coveralls |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
fence/auth.py
Outdated
| """ | ||
| username_deny_regex = username_deny_regex or config["GLOBAL_USERNAME_DENY_REGEX"] | ||
| if username_deny_regex: | ||
| if re.match(pattern=username_deny_regex, string=username): |
There was a problem hiding this comment.
perhaps we'd like to use re.search? https://stackoverflow.com/questions/180986/what-is-the-difference-between-re-search-and-re-match
tests/login/test_login_user.py
Outdated
| db_session.add(test_user) | ||
| db_session.commit() | ||
|
|
||
| with pytest.raises(Exception): |
There was a problem hiding this comment.
Consider changing Exception to Unauthorized, test may pass even if an unrelated exception is raised
There was a problem hiding this comment.
Nice! Good catch! PR has been updated.
| assert flask.session["provider"] == provider | ||
| assert flask.session["user_id"] == user_id | ||
| assert flask.g.user == test_user | ||
|
|
There was a problem hiding this comment.
Consider adding a positive test to check the regex is allowing valid cases
There was a problem hiding this comment.
Good idea. Additional test has been added.
Please find the detailed integration test report here Please find the Github Action logs here |
pyproject.toml
Outdated
| @@ -1,3 +1,3 @@ | |||
| [tool.poetry] | |||
| name = "fence" | |||
| version = "11.3.2" | |||
There was a problem hiding this comment.
one last thing, version bump :)
There was a problem hiding this comment.
Nice, thank you! Version updated.
Please find the detailed integration test report here Please find the Github Action logs here |
BinamB
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates PR-1239 by merging master and moving deny-logic to renamed method.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes