Skip to content

Conversation

@ajfriend
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Sep 28, 2020

Coverage Status

Coverage remained the same at 99.187% when pulling de3d1c5 on ajfriend:pre37 into 2c41e74 on uber:master.

@ajfriend
Copy link
Collaborator Author

I'm going through the instructions in RELEASE.md:

1. Create a PR "Preparing for release X.Y.Z" against master branch
    * Alter CHANGELOG.md from `[Unreleased]` to `[X.Y.Z] YYYY-MM-DD`
    * Run `make update-version` and give `X.Y.Z` when prompted
    * Check that all merges that need to be in the changelog are present

but I'm getting an error:

❯ make update-version
Scanning dependencies of target update-version
Current version: 3.7.0
Could not locate v3.7.0 as a Git revision.

Do I need to make a v3.7.0 tag locally first? Or do I wait to do that on Github?

CHANGELOG.md Outdated
- exactEdgeLengthM
- refactor `getH3UnidirectionalEdgeBoundary` for accuracy at small resolutions (#391)
- speeds up `getH3UnidirectionalEdgeBoundary` by about 3x
- implement core logic for future vertex mode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding. Technically I guess this is a "fix", rather than a feature, but I think this is fine.

@dfellis
Copy link
Collaborator

dfellis commented Sep 28, 2020

I'm going through the instructions in RELEASE.md:

1. Create a PR "Preparing for release X.Y.Z" against master branch
    * Alter CHANGELOG.md from `[Unreleased]` to `[X.Y.Z] YYYY-MM-DD`
    * Run `make update-version` and give `X.Y.Z` when prompted
    * Check that all merges that need to be in the changelog are present

but I'm getting an error:

❯ make update-version
Scanning dependencies of target update-version
Current version: 3.7.0
Could not locate v3.7.0 as a Git revision.

Do I need to make a v3.7.0 tag locally first? Or do I wait to do that on Github?

We need to wait on @isaacbrodsky here, as I believe he has done most of the releases in the past? You're probably right about needing to run git tag v3.7.0 yourself, but 1) why? 2) why is this not in the instructions? So would be best to confirm.

@isaacbrodsky
Copy link
Collaborator

I'm going through the instructions in RELEASE.md:

1. Create a PR "Preparing for release X.Y.Z" against master branch
    * Alter CHANGELOG.md from `[Unreleased]` to `[X.Y.Z] YYYY-MM-DD`
    * Run `make update-version` and give `X.Y.Z` when prompted
    * Check that all merges that need to be in the changelog are present

but I'm getting an error:

❯ make update-version
Scanning dependencies of target update-version
Current version: 3.7.0
Could not locate v3.7.0 as a Git revision.

Do I need to make a v3.7.0 tag locally first? Or do I wait to do that on Github?

We need to wait on @isaacbrodsky here, as I believe he has done most of the releases in the past? You're probably right about needing to run git tag v3.7.0 yourself, but 1) why? 2) why is this not in the instructions? So would be best to confirm.

The script expects the last published version. You will be prompted for the next version number after you specify the current version (probably should be read from VERSION instead of prompting).

@ajfriend ajfriend merged commit c99cad0 into uber:master Sep 30, 2020
@ajfriend ajfriend deleted the pre37 branch September 30, 2020 01:02
mrdvt92 pushed a commit to mrdvt92/h3 that referenced this pull request Jun 19, 2022
* update changelog and fix @defgroup for exactEdgeLength

* update docs

* Changelog: Change CHANGELOG to match style of previous CHANGELOG changes

* get reeeealy specific in the release steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants