Skip to content

Conversation

@isaacbrodsky
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jul 4, 2022

Coverage Status

Coverage remained the same at 98.66% when pulling 9f6836c on isaacbrodsky-patch-1 into dbe1b7c on master.

@ajfriend
Copy link
Collaborator

ajfriend commented Jul 5, 2022

Awesome! Super excited for the DuckDB bindings!

Also, it looks like you're having the same build issues as i was having in #617 . Something must have changed with the Windows containers?

@isaacbrodsky
Copy link
Collaborator Author

Awesome! Super excited for the DuckDB bindings!

Also, it looks like you're having the same build issues as i was having in #617 . Something must have changed with the Windows containers?

Yes, it appears the docs build has failed. #617 (comment) Perhaps some graphviz/dot/doxygen update happened or a component was removed. I think we can simply disable building docs in the Windows CI, or try something like https://github.com/marketplace/actions/install-graphviz

Copy link
Collaborator

@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!

@isaacbrodsky isaacbrodsky force-pushed the isaacbrodsky-patch-1 branch from 77bea1a to 9f6836c Compare July 5, 2022 17:15
Copy link
Collaborator

@dfellis dfellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@isaacbrodsky isaacbrodsky merged commit 1e661dc into master Jul 5, 2022
@isaacbrodsky isaacbrodsky deleted the isaacbrodsky-patch-1 branch July 5, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants