Vertex optimizations, first pass #422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimizations for
cellToVertex. The main benefit of this work was to identify the key perf bottleneck, which is the call to_h3ToFaceIjkinvertexRotations. The optimizations here are mainly to avoid expensive calls:directionForNeighbor.This improves things, but doesn't add up as much as I'd like - approx 20% speedup:
Before
After
I think I can improve on this significantly by refactoring
cellToVertexesto avoid repeated calculations for the origin and neighbors, but that will come in a later PR.