Refine error wrapper heuristic #369
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 87.60% 87.47% -0.13%
==========================================
Files 73 73
Lines 10848 10864 +16
==========================================
Hits 9503 9503
- Misses 1155 1167 +12
- Partials 190 194 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuxincs
approved these changes
Oct 17, 2025
| for sig, act := range _assumeReturns { | ||
| if sig.match(pass, call) { | ||
| return act(call) | ||
| return act(call), true |
There was a problem hiding this comment.
trigger's nilability implies this boolean value, right? shouldn't we just do that?
Comment on lines
+552
to
+568
| func IsError(pass *analysishelper.EnhancedPass, expr ast.Expr) bool { | ||
| t := pass.TypesInfo.TypeOf(expr) | ||
| if t == nil { | ||
| return false | ||
| } | ||
| // Check if expr represents an implementation of the error interface | ||
| return implementsError(t) | ||
| } | ||
|
|
||
| // implementsError checks if the given object implements the error interface. It also covers the case of | ||
| // interfaces that embed the error interface. | ||
| func implementsError(t types.Type) bool { | ||
| if ErrorInterface == nil { | ||
| return false | ||
| } | ||
| return types.Implements(t, ErrorInterface) | ||
| } |
There was a problem hiding this comment.
can we attach these directly to analysishelper.EnhancedPass such that we do not have to pass it around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the error wrapping heuristic to cover:
return NewInternalServerError("some error message"))return Wrapf(Wrapf(Wrapf(NewError(err.Error())))))