Skip to content

[Mockgen] Archive mode make interfaces optional #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
linzhp merged 1 commit into from
Dec 17, 2025
Merged

[Mockgen] Archive mode make interfaces optional #295

linzhp merged 1 commit into from
Dec 17, 2025

Conversation

@lverma14
Copy link
Contributor

@lverma14 lverma14 commented Dec 17, 2025 •
edited
Loading

This diff adds logic to archive mode:

  • Keep interfaces optional as in the original Archive mode PR.
  • We already have logic to discover interfaces. This diff reuses the logic with some constraints & updates the initial arg checker to make interfaces optional.
  • Rest of the modes expected to work as before.

Additionally:

  • Updated the Module.bazel's rules_go version = "0.59.0" to be compatible with latest Bazel.
    Without that was seeing error :
"/home/runner/.bazel/external/rules_go+/go/private/extensions.bzl", line 430, column 28, in _download_sdk
		sdks_by_version.clear()
Error: 'Facts' value has no field or method 'clear'
ERROR: error evaluating module extension @@rules_go+//go:extensions.bzl%go_sdk

Verified running locally through Test:

vermal@vermal-Y05654GT6T bazel % cd bazel && bazel test ...  
INFO: Found 9 targets and 3 test targets...
INFO: Elapsed time: 96.579s, Critical Path: 54.34s
INFO: 83 processes: 16 internal, 67 darwin-sandbox.
INFO: Build completed successfully, 83 total actions
//tests/archive:client_test                                              PASSED in 0.8s
//tests/source:client_test                                               PASSED in 0.5s
//tests/source_with_importpath:client_test                               PASSED in 0.9s

Internal Ref : BUILD-440, GH: #294

@lverma14 lverma14 marked this pull request as draft December 17, 2025 00:08
@lverma14 lverma14 force-pushed the vermal/archive-interfaces branch from af4bdde to f82b608 Compare December 17, 2025 00:48
@lverma14 lverma14 marked this pull request as ready for review December 17, 2025 00:55
@lverma14 lverma14 requested a review from linzhp December 17, 2025 00:55
JacobOaks
JacobOaks approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@JacobOaks JacobOaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus a test cleanup suggestion

linzhp
linzhp reviewed Dec 17, 2025
View reviewed changes
@lverma14 lverma14 force-pushed the vermal/archive-interfaces branch 2 times, most recently from 48caa67 to 6f66ad8 Compare December 17, 2025 19:23
linzhp
linzhp approved these changes Dec 17, 2025
View reviewed changes
@lverma14 lverma14 force-pushed the vermal/archive-interfaces branch from 6f66ad8 to a50f663 Compare December 17, 2025 20:44
@linzhp linzhp merged commit 349aac6 into uber-go:main Dec 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linzhp linzhp linzhp approved these changes

@JacobOaks JacobOaks JacobOaks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lverma14 @linzhp @JacobOaks