Remove context error check in lifecycle #1034
Conversation
There was a problem hiding this comment.
Hello @yux0 ,
Thank you for taking the time to contribute but please follow our guidelines for contributing. We do request issues are filed to describe the change you are contributing to ensure the maintainers are aligned with the changes.
Unfortunately, this change is rather something we would not do because it is an explicit design choice. Not all user hooks provided to fx respect context, so the framework can't assume that they do.
On that note, there is an issue that spawned up an internal design note on how we can support different implementations of lifecycles - ex. customizable lifecycle for Fx so that you can implement things such as this. I will share that in the form of GitHub issue shortly and link this PR there too, so you can follow along there once that is posted.
The context canceled or deadline exceeded errors should be handled by user hooks.
E.g.
Hook 1 did not stop because of context expired.