rm --preserve-root should work on symlink too #9706
+185
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8f5724 to
a94c698
Compare
a94c698 to
77ab2ed
Compare
|
GNU testsuite comparison: |
ChrisDryden
reviewed
Dec 19, 2025
| // Use symlink_metadata to get the actual target's dev/ino | ||
| // after following symlinks (we need to follow the symlink to see | ||
| // where it points) | ||
| if let Ok(metadata) = fs::metadata(path) { |
Collaborator
There was a problem hiding this comment.
I think the MacOS tests are failing here because its unable to get the metadata even though its root. Adding a canonicalize to here so that in the MacOS case where the tests are failing, even though:
// First check the simple path-based case (e.g., "/")
let path_looks_like_root = path.has_root() && path.parent().is_none();
This exists, if you can't get the metadata it will still fail if the canonicalize returns a "/" after this step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9705