fix(install): preserve setuid/setgid bits after chown operations #9150
+234
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
6d3cf3b to
370c1e7
Compare
|
GNU testsuite comparison: |
370c1e7 to
bff0098
Compare
|
GNU testsuite comparison: |
Special permission bits were being lost when install chowned files, since chown inherently strips setuid/setgid bits for security. This changes the install command to apply a second chmod after chown to preserve those bits. The fix: - Uses libc::chmod for proper special bit support - Updates error handling with io::Error conversion - Adds comprehensive test coverage - Maintains behavior for non-special permissions
bff0098 to
c9eff3e
Compare
|
GNU testsuite comparison: |
c6513d5 to
02f294e
Compare
CodSpeed Performance ReportMerging #9150 will improve performances by 3.86%Comparing Summary
Benchmarks breakdown
Footnotes |
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9134
install -m4755failed to set special permission bits because chown strips them for security. Added second chmod call after chown and improved error handling with libc::chmod for proper special bit support. Updated callers to handle io::Error and added localized error messages. and tests included.