Architect Unit Tests #108
Merged
Architect Unit Tests #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DM1122
requested changes
Sep 30, 2022
Member
DM1122
left a comment
There was a problem hiding this comment.
Its all coming together now 😎. Just check out that one test I mentioned that seems to fail on my end
tests/test_systems/test_spectrometers/test_HyperspectralImager.py
Outdated
Show resolved
Hide resolved
tests/test_systems/test_spectrometers/test_HyperspectralImager.py
Outdated
Show resolved
Hide resolved
Co-authored-by: David Maranto <[email protected]>
Co-authored-by: David Maranto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented:
Accidentally completed get_sensor_spectral_resolution() - Can be overwritten by other PR
Altered get_n_bin() in sensors.py
Added get_n_px() in sensors.py
Added get_size() in masks.py