Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 9, 2025

This PR addresses all npm run lint issues on the main branch that were causing CI failures.

Issues Fixed

Unused Variable Errors (8 errors)

  • check-documentation-links.ts: Removed unused output_format and semaphore variables, prefixed unused documentationPath parameter with _
  • evaluate-readme-health.ts: Prefixed unused function parameters repoContext and projectType with _ to indicate they are intentionally unused
  • readme-best-practices.ts: Removed unused readmeExists variable and fixed const declaration

Console Statement Warnings (53 warnings)

  • Updated ESLint configuration to allow console statements in benchmark and script files (src/benchmarks/**/*.ts and src/scripts/**/*.ts)
  • This is appropriate since these files are specifically for debugging, performance testing, and CLI output

Changes Made

  1. Removed truly unused variables that serve no purpose in the code
  2. Prefixed intentionally unused parameters with _ following ESLint conventions
  3. Added ESLint overrides to allow console statements in appropriate file types where they are expected

Verification

  • npm run lint now passes with exit code 0
  • npm run build continues to work without errors
  • npm run test passes all 192 tests
  • npm run typecheck passes without type errors

The changes are minimal and surgical, maintaining existing functionality while ensuring code quality standards are met.

Fixes #22.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • httpstat.us
    • Triggering command: /usr/local/bin/node /home/REDACTED/work/documcp/documcp/node_modules/jest-worker/build/workers/processChild.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] [Bug]: npm run lint issues on main branch Fix npm run lint issues - resolve 61 linting problems (8 errors, 53 warnings) Sep 9, 2025
Copilot AI requested a review from tosin2013 September 9, 2025 23:49
Copilot finished work on behalf of tosin2013 September 9, 2025 23:49
@tosin2013 tosin2013 marked this pull request as ready for review September 10, 2025 00:01
@tosin2013 tosin2013 merged commit 36e5b82 into main Sep 10, 2025
7 of 9 checks passed
@tosin2013 tosin2013 deleted the copilot/fix-22 branch September 10, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: npm run lint issues on main branch

2 participants