Hi @KedoKudo,

Thanks for proposing some new features for tomopy. It looks like your changes broke all of our tests. Check out the tests section of our development documentation to read about how to run the tests on your local machine. Please give me a shout if you run into problems.

It seems to me that the tests failed because of the testing environment (the current testing environment cannot handle new f-string formatting, and missing package Pandas). On my local machine (python3), all tests passed without any issues (see test.log for more details).

That's right, the f formatting is a py3.6+ feature. For robust code in py2.7 and py3.5+, refactor (as an example):

f"report/{reportfn}.pdf"

to

"report/{}.pdf".format(reportfn)

or (even more robust)

os.path.join("report", "{}.pdf".format(reportfn))

The py36 build fails not for the f-string formatting but this error:

Failure: ModuleNotFoundError (No module named 'pandas') ... ERROR

@KedoKudo,

Thanks in advance for you patience. As prjemian mentioned, tomopy targets python 2.7 and 3.5+ on Linux, macOS, and Windows. It may take a few days for your code to be fully reviewed. Expect that I will be asking a lot of questions and asking for more changes in order to ensure that the tomopy API doesn't break without good reason.

Coverage decreased (-1.1%) to 48.764% when pulling 8d61858 on KedoKudo:master into a50ce62 on tomopy:master.

Coverage decreased (-0.8%) to 49.027% when pulling 25b301f on KedoKudo:master into e8911b1 on tomopy:master.

Thanks again, @KedoKudo for this pull request. It looks good to me, but I think @dgursoy had a question about something. He will ask or merge this pull request when he gets back from vacation.

Thanks @KedoKudo! Could you please resolve the conversations that you fixed or edited in your final commits that doesn't need my feedback? This way I can see which ones are resolved and which ones are still open.

@dgursoy I have resolved the conversations that do not require further feedback. A few extra docstring edits have been made to address the new comments posted today.

@KedoKudo Thanks! All looks good.