Support setting model thread stack size #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the scheduler's threads in the stack of Scheduler::run since they're only actually used during that call.
Instead of creating a generator for each possible thread at the beginning, create threads and backing generators as they are spawned by the test cases. This allows us to provide a stack size when spawning a scheduler thread, which can be set via the thread Builder. Fixes tokio-rs#309
9397403 to
ac75e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
loom::thread::Builder::stack_sizenot a no-op. This is done by spawning scheduler threads later such that the requested stack size can be applied then.Fixes #309