Add readline-style line editing keybindings #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ctrl-F, Ctrl-H, Ctrl-K, Ctrl-W) Implements full-featured line editing in search buffer with cursor positioning: - Ctrl-A: Move to beginning of line - Ctrl-E: Move to end of line - Ctrl-B: Move cursor backward one character - Ctrl-F: Move cursor forward one character - Ctrl-H/Backspace: Delete character before cursor - Ctrl-K: Delete from cursor to end of line - Ctrl-W: Delete word backward (stops at alphanumeric boundaries) Key changes: - Added separate text cursor position (@input_cursor_pos) from navigation cursor - Cursor now renders by inverting character at its position using ANSI codes - Characters can be inserted/deleted at arbitrary positions in buffer - Removed Ctrl-J from down navigation (was conflicting with Enter) - Removed Ctrl-K from up navigation (now used for line editing) Updated spec with separated Navigation and Line Editing sections, and added comprehensive test coverage for all new keybindings with specific, predictable assertions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements full-featured line editing in search buffer with cursor positioning:
Also updated spec and added tests.