Skip to content

Fix node-redis createCluster normalized client #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix node-redis createCluster normalized client #427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2eeb63
fix node-redis cluster normalisation
stijnveenman Apr 9, 2025
c914e47
fix prettier formatting
stijnveenman Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ export class RedisStore extends Store {

// Create a redis and ioredis compatible client
private normalizeClient(client: any): NormalizedRedisClient {
let isRedis = "scanIterator" in client
let isRedis = "scanIterator" in client || "masters" in client
let isRedisCluster = "masters" in client

return {
get: (key) => client.get(key),
set: (key, val, ttl) => {
Expand All @@ -63,6 +65,22 @@ export class RedisStore extends Store {
expire: (key, ttl) => client.expire(key, ttl),
mget: (keys) => (isRedis ? client.mGet(keys) : client.mget(keys)),
scanIterator: (match, count) => {
// node-redis createCluster impl.
if (isRedisCluster) {
return (async function* () {
for (const master of client.masters) {
const nodeClient = await client.nodeClient(master)

for await (const key of nodeClient.scanIterator({
COUNT: count,
MATCH: match,
})) {
yield key
}
}
})()
}

if (isRedis) return client.scanIterator({MATCH: match, COUNT: count})

// ioredis impl.
Expand Down