Skip to content

Added the disabling PaX's mprotect() during an activation. #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2015
Merged

Added the disabling PaX's mprotect() during an activation. #305

merged 1 commit into from
Sep 16, 2015

Conversation

@chrootsu
Copy link
Contributor

@chrootsu chrootsu commented Sep 15, 2015

This is necessary to copy a flag XATTR_PAX.

@maxrimue
Copy link
Contributor

maxrimue commented Sep 16, 2015

Sorry, could you provide some more information about what this flag really changes?

@chrootsu
Copy link
Contributor Author

chrootsu commented Sep 16, 2015

The flag disables mprotect(). This PR corrects an omission in #228

@maxrimue
Copy link
Contributor

maxrimue commented Sep 16, 2015

I just tried using n with this patch on OS X, and it throws this error for me:

n max$ ./bin/n 4.0.0

     install : node-v4.0.0
       mkdir : /usr/local/n/versions/node/4.0.0
       fetch : https://nodejs.org/dist/v4.0.0/node-v4.0.0-darwin-x64.tar.gz
######################################################################## 100,0%
cp: illegal option -- -
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file ... target_directory
cp: illegal option -- -
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file ... target_directory
cp: illegal option -- -
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file ... target_directory
cp: illegal option -- -
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvX] source_file ... target_directory
   installed : v4.0.0

And since this error doesn't occur without this change, there must be something wrong with the patch. Ideas?

@chrootsu
Copy link
Contributor Author

chrootsu commented Sep 16, 2015

I have no experience with OS X, but it looks like cp has no option --prevent. I'll try to fix it another way.

@chrootsu chrootsu force-pushed the copy-xattr-when-activate branch from c63853e to 4ba566c Compare September 16, 2015 19:58
@chrootsu chrootsu changed the title Added the copying of extended attributes during an activation. Added the disabling PaX's mprotect() during an activation. Sep 16, 2015
@chrootsu
Copy link
Contributor Author

chrootsu commented Sep 16, 2015

@maxrimue Could you check again, please? Now it should work correctly.

@chrootsu chrootsu force-pushed the copy-xattr-when-activate branch from 4ba566c to cefebb2 Compare September 16, 2015 20:02
@maxrimue
Copy link
Contributor

maxrimue commented Sep 16, 2015

Yep, now it works, thanks!

maxrimue added a commit that referenced this pull request Sep 16, 2015
@maxrimue
Merge pull request #305 from chrootsu/copy-xattr-when-activate
1388dd0 
Added the disabling PaX's mprotect() during an activation.
@maxrimue maxrimue merged commit 1388dd0 into tj:master Sep 16, 2015
@chrootsu
Copy link
Contributor Author

chrootsu commented Sep 16, 2015

Thank you! ^_^

@maxrimue
Copy link
Contributor

maxrimue commented Sep 16, 2015

No problem 👍

@chrootsu chrootsu deleted the copy-xattr-when-activate branch October 14, 2015 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrootsu @maxrimue @bitdivine