This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Enable upstream jaeger storage integration tests in e2e test #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b4f017 to
ed356d4
Compare
2 tasks
ed356d4 to
f04760f
Compare
e9a0c7f to
d43b582
Compare
alejandrodnm
approved these changes
Oct 6, 2022
niksajakovljevic
approved these changes
Oct 7, 2022
|
Similar change in jaeger-clickhouse has been merged. |
cevian
approved these changes
Oct 14, 2022
| "event", | ||
| "link", | ||
| } { | ||
| // ignore any error |
There was a problem hiding this comment.
why are we ignoring these errors, seem future tests will get messed up if there is an error
There was a problem hiding this comment.
Will fixed it. Thanks.
…esponse Signed-off-by: Arunprasad Rajkumar <[email protected]>
d43b582 to
a241935
Compare
cevian
approved these changes
Oct 14, 2022
a241935 to
2a285c5
Compare
This commit reuses fixtures from upstream jaeger[1] which is exposed as golang pkg. Though we use non release version v1.38.2-0.20221006002917-5bf8a28fe06d, it doesn't have any other changes except [1] which is safe. [1] jaegertracing/jaeger#3944 Signed-off-by: Arunprasad Rajkumar <[email protected]>
This would help us to live with few failing tests. Signed-off-by: Arunprasad Rajkumar <[email protected]>
The above test has events which has timestamp difference of ~17hrs when comparing to span. Signed-off-by: Arunprasad Rajkumar <[email protected]>
Jaeger integration test requires storage specific clean up function which should clear state of previous test execution. Currently we implement the requirement by truncating _ps_trace.{span, event, link} tables which has span specific data.
Signed-off-by: Arunprasad Rajkumar <[email protected]>
Jaeger storage integration tests passes span to SpanWriter and uses same span object to verify against result. We mutate given span to encode binary tags and this causes test change in test expectation. This commit adds a simple `copyingSpanWriter` which copies tags before passing down to SpanWriter. Signed-off-by: Arunprasad Rajkumar <[email protected]>
Signed-off-by: Arunprasad Rajkumar <[email protected]>
2a285c5 to
6d158d9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit reuses fixtures from upstream jaeger[1] which is exposed as golang pkg.
Though we use non release version
v1.38.2-0.20221006002917-5bf8a28fe06d, it doesn't have any other changes except [1] which is safe.This PR also fixes
TestJaegerStorageIntegration/*/GetOperationstest which was failing due to a typo.Note: Currently we exclude
FindTraces/Tags_+_Operation_nametest which is still failing after merging both #1681 and #1678. New bug has been created to address the same.[1] jaegertracing/jaeger#3944
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: