This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Fix double counting while populating promscale_sql_database_chunks_count metric
#1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f404d46 to
9a93512
Compare
d3df82c to
ff5de89
Compare
alejandrodnm
approved these changes
Jul 15, 2022
…unt metric Problem statment: `PromscaleCompressionLow` alert fires regardless of a good compression ratio. Root cause: SQL query which populates `promscale_sql_database_chunks_count` is a sum of the below metrics, 1) Uncompressed Chunks 2) Proxy Chunks which points to Compressed Chunks 3) Compressed Chunks However the total chunk count should be just (1) + (3), because (2) is already pointing to (3) and which leads to double counting. Solution: Fix the SQL query to consider entries which has `compressed_chunk_id` as null and this will be true for both (1) and (3). Signed-off-by: Arunprasad Rajkumar <[email protected]>
ff5de89 to
3a14dd3
Compare
Co-authored-by: James Guthrie <[email protected]>
JamesGuthrie
approved these changes
Jul 15, 2022
antekresic
approved these changes
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem statment
PromscaleCompressionLowalert fires regardless of a good compression ratio.Root cause
SQL query which populates
promscale_sql_database_chunks_countis a sum of the below metrics,However the total chunk count should be just (1) + (3), because (2) is already pointing to (3) and which leads to double counting.
Solution
Fix the SQL query to consider entries which has
compressed_chunk_idas null and this will be true for both (1) and (3).Signed-off-by: Arunprasad Rajkumar [email protected]
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: