Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

harkishen
Copy link
Member

@harkishen harkishen commented Jun 10, 2022

Signed-off-by: Harkishen-Singh [email protected]

Fixes: https://github.com/timescale/o11y-team-applications/issues/182

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

  • CHANGELOG entry for user-facing changes
  • Updated the relevant documentation

@harkishen harkishen self-assigned this Jun 13, 2022
@harkishen harkishen marked this pull request as ready for review June 13, 2022 09:59
@harkishen harkishen requested review from a team and antekresic as code owners June 13, 2022 09:59
@harkishen harkishen added this to the post-0.11.0 milestone Jun 13, 2022
Copy link
Contributor

@niksajakovljevic niksajakovljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho this is over-engineered. The code could be simplified a lot. We only need to reload rules.

@harkishen harkishen force-pushed the hot_reload_arch branch 3 times, most recently from 9f1fb1e to 2b6f4ec Compare June 14, 2022 11:09
Copy link
Contributor

@niksajakovljevic niksajakovljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd just like to see some tests (either unit or e2e)

@harkishen harkishen requested a review from a team as a code owner June 14, 2022 13:18
@harkishen harkishen force-pushed the hot_reload_arch branch 2 times, most recently from e293e67 to 234ac99 Compare June 15, 2022 09:10
@harkishen harkishen requested a review from antekresic June 15, 2022 09:12
@harkishen harkishen enabled auto-merge (rebase) June 15, 2022 13:23
@harkishen harkishen merged commit 8739804 into timescale:master Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants