Skip to content

Conversation

@timerring
Copy link
Owner

@timerring timerring commented Mar 11, 2025

Description

This PR mainly redesign the log module via the official lib logging, and I detach the info with different level, which will facilitate the debug process. And merge more process logs into one log file, along with adjusting the logs based on time rather than previous on the basis of one execution.

Besides, to better support the Docker design, I will no longer use nohup to run processes in the background. This is because there is no need to retain duplicate logs. Instead, I suggest running the module directly via tmux or similar methods.

Related Issues

fix #183

Who Can Review?

@timerring

Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@timerring timerring self-assigned this Mar 11, 2025
Copy link
Owner Author

@timerring timerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wait for test.

@timerring timerring merged commit ed6715b into main Mar 11, 2025
@timerring timerring deleted the dev branch March 11, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Design a new log module

1 participant