Skip to content

refactor: pre production version #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

refactor: pre production version #86

merged 1 commit into from
Nov 27, 2024

Conversation

@timerring
Copy link
Owner

@timerring timerring commented Nov 27, 2024 •
edited
Loading

Description

Refactor the project formally, which can be use in production.

Related Issues

None

Changes Proposed

  • move the utils into src
  • merge the upload into src/uploadRrocess
  • adjust some configurations of DanmakuFactory.

Who Can Review?

@timerring

Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@timerring timerring added the enhancement New feature or request label Nov 27, 2024
@timerring timerring self-assigned this Nov 27, 2024
timerring
timerring commented Nov 27, 2024
View reviewed changes
Copy link
Owner Author

@timerring timerring left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's alright. Wait for the test before merging. Hold off merging until the test has been done.

@timerring
Copy link
Owner Author

Pass test.

@timerring timerring merged commit 29ea0e0 into main Nov 27, 2024
@timerring timerring deleted the dev branch November 27, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@timerring timerring

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@timerring