Remove dead code from test-timber-loader #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our hoster notified us about possible security issues with the `open_basedir` override (`Atomicorp.PHP.Bypass.OpenBaseDir`). It's commented out so removing the code doesn't change anything. There's also no reason that the code should be there in the first place.
Codecov Report
@@ Coverage Diff @@
## master #1457 +/- ##
=========================================
Coverage 93.96% 93.96%
Complexity 1415 1415
=========================================
Files 46 46
Lines 3415 3415
=========================================
Hits 3209 3209
Misses 206 206Continue to review full report at Codecov.
|
Member
|
Thanks @matteodem. You're right, that def. doesn't need to be there — good riddance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Our hoster notified us about possible security issues with the
open_basediroverride (Atomicorp.PHP.Bypass.OpenBaseDir). It's commented out so removing the code doesn't change anything. There's also no reason that the code should be there in the first place.Solution
Removing dead / commented out code.
Impact
No notifications of virus scanning softwares about vulnerabilities in the test-timber-loader file.