Skip to content

throw error if public key is not set, yet #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2014
Merged

throw error if public key is not set, yet #27

merged 3 commits into from
Dec 7, 2014

Conversation

joscha
Copy link
Collaborator

@joscha joscha commented Nov 30, 2014

When using crx and trying to generate an App ID prior to generating the public key, an error occurs:

  1) lib/autoupdate should build an autoupdate XML file with codebase and with update_url:
     TypeError: Not a string or buffer
      at Hash.update (crypto.js:240:17)
      at Object.ChromeExtension.generateAppId (/Users/joscha/Development/grunt-crx/node_modules/crx/src/crx.js:291:8)
      at Object.ChromeExtension.generateUpdateXML (/Users/joscha/Development/grunt-crx/node_modules/crx/src/crx.js:314:46)
      at generateXML (/Users/joscha/Development/grunt-crx/lib/autoupdate.js:35:25)
      at /Users/joscha/Development/grunt-crx/node_modules/grunt/node_modules/async/lib/async.js:486:21
      at /Users/joscha/Development/grunt-crx/node_modules/grunt/node_modules/async/lib/async.js:185:13
      at iterate (/Users/joscha/Development/grunt-crx/node_modules/grunt/node_modules/async/lib/async.js:108:13)
      at /Users/joscha/Development/grunt-crx/node_modules/grunt/node_modules/async/lib/async.js:119:25
      at /Users/joscha/Development/grunt-crx/node_modules/grunt/node_modules/async/lib/async.js:187:17
      at /Users/joscha/Development/grunt-crx/node_modules/grunt/node_modules/async/lib/async.js:491:34
      at generatePublicKey (/Users/joscha/Development/grunt-crx/lib/autoupdate.js:28:18)
...

thom4parisot pushed a commit that referenced this pull request Dec 7, 2014
Merge pull request #27 from joscha/throw-error-if-public-key-not-set
27d8498 
throw error if public key is not set, yet
@thom4parisot thom4parisot merged commit 27d8498 into thom4parisot:master Dec 7, 2014
@thom4parisot thom4parisot modified the milestone: 3.0.0 Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@joscha @thom4parisot